Re: [PATCH] mtip32xx: switch to vmalloc() to mitigate high order allocation failures

From: Joe Perches
Date: Fri Mar 14 2014 - 03:48:17 EST


On Thu, 2014-03-13 at 15:57 -0700, Sam Bradshaw wrote:
> The mtip_port kmalloc() allocation is relatively high order, in
> particular since the recent doubling of the size of the scatterlist
> container. The allocation has been shown to fail during SRSI under
> fragmented or low memory conditions. Switching to vmalloc() mitigates
> the problem. Converted both mtip_port and driver_data allocations for
> consistency.

It'd probably be better to use kmalloc and then
only if it fails use vmalloc.

See examples like net/sched/sch_hhf.c


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/