Re: [RFC 4/5] clocksource: omap-timer: Introduce clocksource driver for OMAP SoCs

From: Tony Lindgren
Date: Thu Mar 13 2014 - 16:49:10 EST


* Joel Fernandes <joelf@xxxxxx> [140313 13:43]:
> We introduce functions to initialize clocksource and clockevent, use
> CLOCKSOURCE_OF_DECLARE to declare the clocksource, and handle the clocksource
> selection on a per-SoC basis (Currently only AM335x is supported). Powering up
> of the timer will be done with the help of the mach-omap layer function that's
> introduced earlier in the series.
>
> We make a local copy of dmtimer API for use by clocksource, the original
> dmtimer API in plat-omap is kept as-is till the migration of all SoCs is
> completed after which it can't be deleted.
>
> Signed-off-by: Joel Fernandes <joelf@xxxxxx>
> ---
> drivers/clocksource/Makefile | 1 +
> drivers/clocksource/omap-timer.c | 1157 ++++++++++++++++++++++++++++++++++++++
> drivers/clocksource/omap-timer.h | 422 ++++++++++++++
> 3 files changed, 1580 insertions(+)
> create mode 100644 drivers/clocksource/omap-timer.c
> create mode 100644 drivers/clocksource/omap-timer.h

Hmm this leaves duplicate arch/arm/plat-omap/dmtimer.c code, please
sort out that issue too by allowing omap1 and omap3 still to use
the legacy timer init functions but with timer code under
drivers/clocksource/omap-timer.c.

And not the that drivers/clocksource/omap-timer.h won't be needed at
all, those defines can stay private to the drivers/clocksource/omap-timer.c.

So this patch really should just be moving of the code to the new
location.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/