Re: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn

From: Jason Cooper
Date: Wed Mar 12 2014 - 11:46:55 EST


On Wed, Mar 12, 2014 at 03:02:02PM +0100, Linus Walleij wrote:
> On Fri, Mar 7, 2014 at 2:46 PM, Jason Cooper <jason@xxxxxxxxxxxxxx> wrote:
> > On Fri, Mar 07, 2014 at 11:56:11AM +0800, Linus Walleij wrote:
>
> >> For a single patch?
> >
> > Well, just the doc change and WARN change. I've already taken the dts
> > change into mvebu/dt (for arm-soc).
>
> I've applied this patch [3/3] to the pinctrl tree.

Ok, thanks.

> > There should be no need for these two to be in mvebu's for-next, so if
> > it's easier for you to pick them, please do so.
> >
> > I'll drop them from mvebu/pinctrl and update mvebu's for-next right now.
>
> No, I mean, please apply patch 1/3 and 2/3 to the mvebu tree.
> There is no need to sync DTS and pinctrl driver changes. This
> patch to the pinctrl driver I want to carry however.

Sorry I wasn't clear. patch 2/3 depends on

356ca6ce0aa4 devicetree: bindings: update MVEBU pinctrl binding documentation

Which is in the mvebu/pinctrl branch you have merged into your tree.

I usually keep the binding documentation changes in the same branch with
the code changes so that during a future bisect, the documentation has a
better chance of being consistent with the code at the point of failure.
It's a detail thing, I know, but I couldn't find a downside to doing it.
Well, until now. :-)

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/