Re: [PATCH RESEND 1/3] percpu_ida: Fix data race on cpus_have_tags cpumask

From: Ming Lei
Date: Wed Mar 12 2014 - 07:27:26 EST


On Wed, Mar 12, 2014 at 12:31 AM, Alexander Gordeev <agordeev@xxxxxxxxxx> wrote:
> On Tue, Mar 11, 2014 at 11:34:21PM +0800, Ming Lei wrote:
>> I mean the below block can be put inside the previous lock:
>
> Oh, *now* I see what you mean. Please, ignore my prevous reply.
> Still, we want to release the lock as soon as possible and
> there is no reason to the below bits it under lock.

Actually my comment was wrong because pool->cpus_have_tags
should be guarded by pool->lock instead of the percpu tag->lock.

Sorry for the noise.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/