Re: [PATCH 2/3] soc: keystone: add QMSS driver

From: Santosh Shilimkar
Date: Tue Mar 11 2014 - 10:45:05 EST


On Tuesday 11 March 2014 10:04 PM, Kumar Gala wrote:
>
> On Mar 10, 2014, at 4:19 PM, Santosh Shilimkar <santosh.shilimkar@xxxxxx> wrote:
>
>>>> + -- reg-names : Names for the above register regions. The name to be
>>>> + used is as follows:
>>>> + - "config" : Queue configuration region.
>>>> + - "status" : Queue status RAM.
>>>> + - "region" : Descriptor memory setup region.
>>>> + - "push" : Queue Management/Queue Proxy region.
>>>> + - "pop" : Queue Management/Queue Proxy region.
>>>> + - "peek" : Queue Peek region.
>>>
>>> reg-names should be optional. Also you have the order different from
>>> reg. Be consistent as to what is the correct order.
>>>
>> We thought of using reg-names to remove the ordering to index
>> the regs. So if we make the reg-names optional, then indexing
>> by order will be used. We can do that.
>
> We keep having this conversation, why does reg-names need to be optional for new bindings?
>
I guess the question is for Rob.

Regards,
Santosh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/