Re: [PATCH v6 2/6] pci: OF: Fix the conversion of IO ranges into IO resources.

From: Arnd Bergmann
Date: Sat Mar 08 2014 - 12:18:14 EST


On Wednesday 05 March 2014, Liviu Dudau wrote:
> + unsigned long port = -1;
> + if (!pci_register_io_range(range->cpu_addr, range->size))
> + port = pci_address_to_pio(range->cpu_addr);

I don't remember the outcome of my suggestion to just return 'port' from
pci_register_io_range(). In my mind that would be much simpler than
adding the range in a data structure just so we can look it up in the very
next line.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/