Re: [PATCH 1/1] block: rework flush sequencing for blk-mq

From: Christoph Hellwig
Date: Sat Mar 08 2014 - 10:52:53 EST


On Fri, Mar 07, 2014 at 03:45:09PM -0500, Jeff Moyer wrote:
> Hi, Christoph,
>
> Did you mean to switch from list_add to list_add_tail? That seems like
> a change that warrants mention.

No, that wasn't intentional and should be fixed. Btw, there was another
issue with that commit, in that dm-multipath also needs to allocate
->flush_rq. I saw a patch from Hannes fixing it in the SuSE tree, and
would really love to see him submit that for mainline as well.

Unfortunately SuSE seems to have lots of block and dm fixes and even
features that they don't submit upstream.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/