Re: [GIT PULL] x86 fixes for v3.14-rc6

[Linus Torvalds]

Oww, oww, oww.

DAMMIT.

On Fri, Mar 7, 2014 at 3:25 PM, H. Peter Anvin <hpa@xxxxxxxxxxxxxxx> wrote:
>
> A small collection of minor fixes.  The FPU stuff is still pending, I
> fear.  I haven't heard anything from Suresh so I suspect I'm going to
> have to dig into the init specifics myself and fix up the patchset.

I pulled this and then pushed out without test-compiling, because I'm
not used to the x86 trees causing problems. Usually they've gone
through a lot of build tests etc.

But dammit, it's broken:

  arch/x86/kernel/head_64.o: In function `early_idt_handler':
  (.init.text+0x124): undefined reference to `X86_TRAP_NMI'

because X86_TRAP_NMI is an enum, not a #define.

This can not have worked in your tree either, because that thing has
never been anything *but* an enum. So I'm pissed off. This patch was
clearly never tested anywhere. Why was it sent to me?

Grr. Consider yourself cursed at. Saatana.

              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/