Re: [PATCH] module: LLVMLinux: Remove unused function warning from __param_check macro

[Behan Webster]

On 03/07/14 14:56, PaX Team wrote:
> On 7 Mar 2014 at 11:08, behanw@xxxxxxxxxxxxxxxxxx wrote:
>
> > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
> > index c3eb102..5ce1f67 100644
> > --- a/include/linux/moduleparam.h
> > +++ b/include/linux/moduleparam.h
> > @@ -346,6 +346,7 @@ static inline void destroy_params(const struct kernel_param *params,
> >   /* The macros to do compile-time type checking stolen from Jakub
> >      Jelinek, who IIRC came up with this idea for the 2.4 module init code. */
> >   #define __param_check(name, p, type) \
> > +	static inline type *__check_##name(void) __attribute__ ((unused)); \
> >   	static inline type *__check_##name(void) { return(p); }
> why can't you have the attr on the definition itself:
>
> static inline __unused type *__check_##name(void) { return(p); }
"__unused" isn't defined anywhere I can find, except in:

src/linux/drivers/net/ethernet/amd/declance.c:#define __unused 
__attribute__ ((unused))

But this does work.

-       static inline type *__check_##name(void) { return(p); }
+       static inline __attribute__((unused)) \
+               type *__check_##name(void) { return(p); }

If this is preferred, I will resubmit.

Behan

--
Behan Webster
behanw@xxxxxxxxxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/