Re: [PATCH RFT] regulator: pbias: Convert to use regmap helper functions

[Axel Lin]

2014-03-06 23:20 GMT+08:00 Balaji T K <balajitk@xxxxxx>:
> On Thursday 06 March 2014 06:40 PM, Axel Lin wrote:
>>
>> This patch converts this driver to use the regmap helper functions
>> provided by
>> regulator core.
>>
>> This fixes a few issues in current implementation:
>>
>> 1) In original code, the set voltage does not check max_uV,
>>     which means if request max_uV < 1800000, it will still set the voltage
>>     to 1800000.
>>
>> 2) The is_enable implementation is wrong in some cases:
>>     e.g. for pbias_mmc_omap5: emable_mask is : BIT(27) | BIT(25) | BIT(26)
>>     However, pbias_regulator_enable() only sets BIT(26) | BIT(22) bits.
>>     So is_enable always return false in this case.
>>
>> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
>> ---
>> Hi Balaji,
>> I don't have this h/w, so please test if it works.
>
>
> Hi Axel,
>
> There were few issues when I tried using regmap helper,
> will check on this.

Hi Balaji,

I decide to break this patch to 3 pathes as below:

[PATCH 1/3] regulator: pbias: Fix is_enabled callback implementation
  This is pure bug fix for is_enabled logic

[PATCH 2/3] regulator: pbias: Convert to use regmap helper functions
  This simply convert to use regmap.

[PATCH 3/3] regulator: pbias: Convert to use
regulator_[enable|is_enabled]_regmap
  This one depends on commit ca5d1b3524b4d
 "regulator: helpers: Modify helpers enabling multi-bit control"
  which is currently only available on regulator tree.
  I sent it for review and test now, if it works, I'll resend it once
3.5-rc1 is release.

I'm sending the patches right away.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/