Re: [PATCH 7/9] afs: don't use PREPARE_WORK

From: Tejun Heo
Date: Fri Mar 07 2014 - 10:27:35 EST


On Thu, Feb 20, 2014 at 03:44:29PM -0500, Tejun Heo wrote:
> PREPARE_[DELAYED_]WORK() are being phased out. They have few users
> and a nasty surprise in terms of reentrancy guarantee as workqueue
> considers work items to be different if they don't have the same work
> function.
>
> afs_call->async_work is multiplexed with multiple work functions.
> Introduce afs_async_workfn() which invokes afs_call->async_workfn and
> always use it as the work function and update the users to set the
> ->async_workfn field instead of overriding the work function using
> PREPARE_WORK().
>
> It would probably be best to route this with other related updates
> through the workqueue tree.
>
> Compile tested.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: David Howells <dhowells@xxxxxxxxxx>
> Cc: linux-afs@xxxxxxxxxxxxxxxxxxx

Applied to wq/for-3.15. Please holler if there's any objection.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/