Re: [PATCH] RFC: WIP: sc16is7xx.c

From: Greg KH
Date: Fri Mar 07 2014 - 00:52:12 EST


On Thu, Mar 06, 2014 at 09:35:46PM -0500, jon@xxxxxxxxxx wrote:
> From: Jon Ringle <jringle@xxxxxxxxxxxxx>
>
> I am requesting comments on this serial driver.
> I am currently having some latency issues with it where I experience
> packet loss at speed of 19200.
>
> I welcome any and all comments.

The basic coding style problems make it hard to read to be able to help
review it, sorry.

Yes, brains have patterns, you want to follow the same patterns as
others, it matters.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/