Re: [PATCH] tracing/module: Replace include of tracepoint.h with jump_label.h in module.h

From: Rusty Russell
Date: Thu Mar 06 2014 - 22:40:53 EST


Steven Rostedt <rostedt@xxxxxxxxxxx> writes:
> Rusty,
>
> Can you give an Acked-by for this patch so that I can include it in my
> 3.15 queue. I have some patches there that need to be added before this
> change can go in.

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Thanks,
Rusty.

>
> Thanks,
>
> -- Steve
>
>
> ----
> There's nothing in the module.h header that requires tracepoint.h to be
> included, and there may be cases that tracepoint.h may need to include
> module.h, which will cause recursive header issues.
>
> But module.h requires seeing HAVE_JUMP_LABEL which is set in
> jump_label.h which it just coincidentally gets from tracepoint.h.
>
> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> ---
> include/linux/module.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/module.h b/include/linux/module.h
> index eaf60ff..5a50539 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -15,7 +15,7 @@
> #include <linux/stringify.h>
> #include <linux/kobject.h>
> #include <linux/moduleparam.h>
> -#include <linux/tracepoint.h>
> +#include <linux/jump_label.h>
> #include <linux/export.h>
>
> #include <linux/percpu.h>
> --
> 1.8.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/