Re: [PATCH v12] gpio: add a driver for the Synopsys DesignWare APB GPIO block

[delicious quinoa]

On Thu, Mar 6, 2014 at 7:50 AM, Josh Cartwright <joshc@xxxxxxxxxxxxxx> wrote:
> On Tue, Feb 25, 2014 at 05:01:01PM -0600, Alan Tull wrote:
>> From: Jamie Iles <jamie@xxxxxxxxxxxxx>
>>
>> The Synopsys DesignWare block is used in some ARM devices (picoxcell)
>> and can be configured to provide multiple banks of GPIO pins.
>>
>> Signed-off-by: Jamie Iles <jamie@xxxxxxxxxxxxx>
>> Signed-off-by: Alan Tull <atull@xxxxxxxxxx>
>> Reviewed-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> [..]
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -128,6 +128,15 @@ config GPIO_GENERIC_PLATFORM
>>       help
>>         Say yes here to support basic platform_device memory-mapped GPIO controllers.
>>
>> +config GPIO_DWAPB
>> +     tristate "Synopsys DesignWare APB GPIO driver"
>> +     select GPIO_GENERIC
>> +     select GENERIC_IRQ_CHIP
>> +     depends on OF_GPIO && IRQ_DOMAIN
>> +     help
>> +       Say Y or M here to build support for the Synopsys DesignWare APB
>> +       GPIO block.
>> +
>
> Looks like this hit next-20140306, when just doing a simple 'make defconfig', I get:
>
> kernel/irq/Kconfig:41:error: recursive dependency detected!
> kernel/irq/Kconfig:41:  symbol GENERIC_IRQ_CHIP is selected by GPIO_DWAPB
> drivers/gpio/Kconfig:131:       symbol GPIO_DWAPB depends on IRQ_DOMAIN
> kernel/irq/Kconfig:46:  symbol IRQ_DOMAIN is selected by GENERIC_IRQ_CHIP
>
> Not sure the best course of action here..
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation

The fix is:

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 9979017..0e524d7 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -132,7 +132,7 @@ config GPIO_DWAPB
        tristate "Synopsys DesignWare APB GPIO driver"
        select GPIO_GENERIC
        select GENERIC_IRQ_CHIP
-       depends on OF_GPIO && IRQ_DOMAIN
+       depends on OF_GPIO
        help
          Say Y or M here to build support for the Synopsys DesignWare APB
          GPIO block.

Apologies for missing this.

Alan Tull
aka
delicious quinoa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/