Re: [RFC] [PATCH] Pre-emption control for userspace

[Thomas Gleixner]

On Thu, 6 Mar 2014, Peter Zijlstra wrote:

> On Thu, Mar 06, 2014 at 02:45:00PM +0100, Rasmus Villemoes wrote:
> > Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:
> > 
> > > On Thu, Mar 06, 2014 at 02:24:43PM +0100, Rasmus Villemoes wrote:
> > >> Is it possible to implement non-sleeping versions of {get,put}_user()?
> > >
> > > __{get,put}_user()
> > 
> > Huh?
> > 
> > arch/x86/include/asm/uaccess.h:
> > 
> > /**
> >  * __get_user: - Get a simple variable from user space, with less checking.
> >  * @x:   Variable to store result.
> >  * @ptr: Source address, in user space.
> >  *
> >  * Context: User context only.  This function may sleep.
> > 
> > What am I missing?
> 
> __get_user() -> __get_user_nocheck() -> __get_user_size() -> __get_user_asm()
> 
> And __get_user_asm() seems to generate the required .fixup section for
> this to work in pagefault_disable() context.

Well, it still might sleep if you're using it in page fault enabled
context. So the documentation of that function sucks.

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/