Re: [PATCH net-next v2 12/13] r8152: add additional parameter for non x86 platform

[David Miller]

From: Hayes Wang <hayeswang@xxxxxxxxxxx>
Date: Wed, 5 Mar 2014 14:49:27 +0800

> Add additional parameter for non x86 platform for better throughput.
> 
> Signed-off-by: Hayes Wang <hayeswang@xxxxxxxxxxx>

This commit message tells me absolutely nothing.

First of all, it doesn't say what the issue is, why is the chip
slower on non-x86 platforms with the current way it is programmed?

And in particular, which non-x86 platform?  You can't possibly mean
all of them.

I can almost guarentee if you actually explain the issue, I'm going
to tell you to use a more meaningful test for the condition or
property an architecture has which makes the alternative setting
more desirable.

>  /* USB_RX_EARLY_AGG */
> -#define EARLY_AGG_SUPPER	0x0e832981
> +#if defined(__i386__) || defined(__x86_64__)
> +	#define EARLY_AGG_SUPPER	0x0e832981
> +#else
> +	#define EARLY_AGG_SUPPER	0x0e835000
> +#endif

And this value is completely magic, you must document what this
register value means.

I find this patch series extremely frustrating.

You are combining so many things all at once, so if one aspect
requires changes or to be removed, it invalidates the rest of
the series and you have to respin it all over again.

Why don't you re-submit this in pieces?  First the cleanups
(first three patches) would be one series.

Once I apply that, perhaps submit the locking changes and
tso/checksum support.

Then finally, after I apply that, submit the tweaks at the end.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/