Re: [PATCH v2] mfd: max8997: use regmap to access registers

From: Dmitry Torokhov
Date: Wed Mar 05 2014 - 13:54:52 EST


Hi Robert,

On Wed, Mar 05, 2014 at 03:58:17PM +0100, Robert Baldyga wrote:
>
> -int max8997_write_reg(struct i2c_client *i2c, u8 reg, u8 value)
> +int max8997_write_reg(struct regmap *map, u8 reg, u8 value)

Why don't you make read/write reg to take struct max8997_dev as argument
instead of regmap? regmap seems to be the current implementation du jur,
but that is core's detail, functions do not need to care.

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/