Re: [PATCH] Revert "Bluetooth: Use devname:vhci module alias for virtual HCI driver"

From: Josh Boyer
Date: Wed Mar 05 2014 - 12:50:37 EST


On Wed, Mar 5, 2014 at 11:46 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Thomas,
>
>> Adding the devname:vhci alias and thus adding a static /dev/vhci device node
>> only works when assigning a fixed major/minor number. However, the code
>> currently uses a dynamically assigned minor number. It is therefore impossible
>> to create a static device and to autoload the module when accessing it.
>>
>> Reverting this fixes the kmod error message
>> depmod: ERROR: Module 'hci_vhci' has devname (vhci) but lacks major and minor information. Ignoring.
>>
>> This reverts commit bfacbb9aec029b3200053d84c8cd5d7575f2d4a5.
>
> NAK. We allocated a static minor for this.

Johan mentioned that. Commit b075dd40c95d11c2c8690f6c4d6232fc,
correct? Why isn't that headed into 3.14 right now, and CC'd to
stable? Currently you have a somewhat broken driver in 3.13 and
3.14-rcX that seems to have a pretty clear fix.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/