Re: [PATCH v2 01/11] base: power: Add generic OF-based power domain look-up

From: Tomasz Figa
Date: Wed Mar 05 2014 - 06:54:00 EST


On 04.03.2014 19:23, Stephen Boyd wrote:
On 03/03, Tomasz Figa wrote:
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index dc127e5..006b455 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -3,12 +3,16 @@
*
* Copyright (C) 2011 Rafael J. Wysocki <rjw@xxxxxxx>, Renesas Electronics Corp.
*
+ * Support for Device Tree based power domain providers:
+ * Copyright (C) 2014 Tomasz Figa <tomasz.figa@xxxxxxxxx>
+ *
* This file is released under the GPLv2.
*/

#include <linux/init.h>
#include <linux/kernel.h>
#include <linux/io.h>
+#include <linux/platform_device.h>

Is this still needed?


Probably not.

#include <linux/pm_runtime.h>
#include <linux/pm_domain.h>
#include <linux/pm_qos.h>
[...]
+
+/*
+ * DEVICE<->DOMAIN BINDING USING DEVICE TREE LOOK-UP
+ *
+ * The code below registers a notifier for platform bus devices'
+ * BUS_NOTIFY_BIND_DRIVER events and tries to attach devices to their power
+ * domains by looking them up using Device Tree.
+ *
+ * Similarly in BUS_NOTIFY_UNBOUND_DRIVER the device is detached from its
+ * domain, since it no longer supports runtime PM without any driver bound
+ * to it.

This looks outdated.


Oops, missed this one. Thanks for pointing out.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/