Re: [PATCH v5 2/7] Documentation: of: Document graph bindings

From: Philipp Zabel
Date: Tue Mar 04 2014 - 05:17:25 EST


Hi Sylwester,

Am Freitag, den 28.02.2014, 22:08 +0100 schrieb Sylwester Nawrocki:
> Hi Philipp,
>
> Just couple minor comments...

Thanks, I'll fix all of those.

> On 02/27/2014 06:35 PM, Philipp Zabel wrote:
> > The device tree graph bindings as used by V4L2 and documented in
> > Documentation/device-tree/bindings/media/video-interfaces.txt contain
> > generic parts that are not media specific but could be useful for any
> > subsystem with data flow between multiple devices. This document
> > describe the generic bindings.
>
> s/describe/describes/

[...]

> > +These common bindings do not contain any information about the direction of
>
> s/of/or/ ?

[...]

> > +device_1 {
> > + port {
> > + device_1_output: endpoint {
> > + remote-endpoint =<&device_2_input>;
> > + };
> > + };
> > +};
> > +
> > +device_1 {
>
> s/device_1/device_2/
> But it might be better to use dashes instead of underscores
> for the node names.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/