Re: [PATCH] drivercore: deferral race condition fix

From: Mark Brown
Date: Mon Mar 03 2014 - 23:57:25 EST


On Mon, Mar 03, 2014 at 10:26:59AM +0200, Peter Ujfalusi wrote:

> I think it is correct to detect this situation without the need to have non
> related drivers to be probed.
> The patch is doing this exactly: detects if we had successful parallel driver
> probe(s) while another driver was probing which ends up requesting to be
> deferred. We only try the deferred list again if this condition has been
> detected, we do not loop on the deferred list, we do not try the list again if
> there were no other drivers loaded since nothing happened which could satisfy
> the driver asking to be deferred.

It's certainly the simplest approach I can think of - anything else
would seem to involve looking to see if we're running deferred probes
and trying to add things to the list while that's going on which seems
like it might be hairy.

Attachment: signature.asc
Description: Digital signature