Re: [PATCH 3/3] tracing: introduce a trace_data_offset struct to store array size

From: Steven Rostedt
Date: Mon Mar 03 2014 - 15:48:37 EST


You're right, this one will bring up discussion.

On Fri, 28 Feb 2014 21:32:18 -0800
Filipe Brandenburger <filbranden@xxxxxxxxxx> wrote:

> Commit 7d536cb3f stores the length of the array in the high 16 bits of
> the offset field. Using a struct with two separate 16 bit fields makes
> it cleaner.
>
> Tested: Boot kernel with this change, set a 'filename ~ "/usr/bin/pst*"'
> regex filter on events/sched/sched_process_exec/filter, enabled tracing,
> checked that calling pstree would log the trace event as expected.
>

I just applied this and tested it on my PPC64 box, and it gives me the
following:

without patch:

pst2pdf-3506 [000] 120.700910: sched_process_exec: filename=/usr/bin/pst2pdf pid=3506 old_pid=3506


With patch:

pstopnm-4432 [001] 1490.246765: sched_process_exec: filename= pid=4432 old_pid=4432


-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/