Re: [PATCH] pstore: reset ftrace_read_cnt at ramoops_pstore_open

[Kees Cook]

On Thu, Feb 27, 2014 at 10:37 PM,  <shuox.liu@xxxxxxxxx> wrote:
> From: Liu ShuoX <shuox.liu@xxxxxxxxx>
>
> ftrace_read_cnt need to be reset in open to support mutli times
> getting the records.
>
> Signed-off-by: Liu ShuoX <shuox.liu@xxxxxxxxx>
> ---
>  fs/pstore/ram.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index fa8cef2..a5d0cab 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -101,6 +101,7 @@ static int ramoops_pstore_open(struct pstore_info *psi)
>
>         cxt->dump_read_cnt = 0;
>         cxt->console_read_cnt = 0;
> +       cxt->ftrace_read_cnt = 0;
>         return 0;
>  }

I think we need a separate function for "clear" for the
ramoops_context struct. IIUC, we're missing a similar initialization
in ramoops_probe, which lacks both console_read_cnt=0 and
ftrace_read_cnt=0. Then both places could call this?

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/