Re: [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

[DaeSeok Youn]

I think line break is a solution about long line warning. And
replacing with hex_dump() is better than managing with another patch.
So I said this improvement is separated with another patch.

Just my opinion.
If I'm wrong, I try to change as Krzysztof's comment in same patch.

Thanks.
Daeseok Youn.

2014-03-03 16:10 GMT+09:00 Joe Perches <joe@xxxxxxxxxxx>:
> On Mon, 2014-03-03 at 16:01 +0900, DaeSeok Youn wrote:
>> 2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa <khalasa@xxxxxxx>:
>> > why not use some existing *hex_dump*() instead?
>> OK. but this patch is only for fix line length over 80 characters,
>> right? If it can be improved as your comment,
>> it must be in another patch.
>
> Not true.  Always strive to improve the code in
> preference to shutting up checkpatch warnings.
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/