Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

[Joe Perches]

On Sun, 2014-03-02 at 20:31 +0530, Yogesh Chaudhari wrote:
> Based on the discussion here:
> https://lkml.org/lkml/2014/3/2/17
> 
> I would like to propose this patch to improve the warning message in
> checkpatch.pl.  Comments/Suggestions on possible improvements are
> welcome.

Messages are all single line.

This breaks --terse.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
>              WARN("PREFER_PR_LEVEL",
> -                 "Prefer netdev_$level2(netdev, ... then
> dev_$level2(dev, ... then pr_$level(...  to printk(KERN_$orig ...\n" .
> $herecurr);
> +                 "Order of preference for printing debug messages:
> +                 1. [subsystem]_$level2([subsystem]dev, ... eg
> netdev_$level2(netdev, ... for netdevice object
> +                 2. dev_$level2(dev, ... for drivers with struct device
> +                 3. pr_$level(...  to printk(KERN_$orig ...\n" . $herecurr);
>          }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/