Re: [PATCH 11/19] perf, c2c: Add in sort on physid

[Andi Kleen]

Don Zickus <dzickus@xxxxxxxxxx> writes:
> +
> +	/*
> +	 * must pass period=weight in order to get the correct
> +	 * sorting from hists__collapse_resort() which is solely
> +	 * based on periods. We want sorting be done on nr_events * weight
> +	 * and this is indirectly achieved by passing period=weight here
> +	 * and the he_stat__add_period() function.
> +	 */

sort.c really must be fixed to support multiple sort keys properly.
Lots of other code has workarounds for this too (e.g. it is a bit
problem for TSX abort weights)

I would suggest to fix that instead of hacking around it.

-Andi


-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/