Re: [PATCH v4 4/9] Input: pmic8xxx-keypad - Migrate to DT

[Stephen Boyd]

On 02/27, Josh Cartwright wrote:
> Looks good, with the exception of one thing...
> 
> On Thu, Feb 27, 2014 at 05:55:15PM -0800, Stephen Boyd wrote:
> > The driver is only supported on DT enabled platforms. Convert the
> > driver to DT so that it can probe properly.
> > 
> > Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> > ---
> >  drivers/input/keyboard/pmic8xxx-keypad.c | 150 ++++++++++++++++++-------------
> > @@ -471,50 +514,27 @@ static void pmic8xxx_kp_close(struct input_dev *dev)
> >   */
> >  static int pmic8xxx_kp_probe(struct platform_device *pdev)
> >  {
> [..]
> > -	keymap_data = pdata->keymap_data;
> > -	if (!keymap_data) {
> > -		dev_err(&pdev->dev, "no keymap data supplied\n");
> > -		return -EINVAL;
> > -	}
> > +	repeat = !of_property_read_bool(pdev->dev.of_node,
> > +					"linux,input-no-autorepeat");
> > +	wakeup = !of_property_read_bool(pdev->dev.of_node,
> > +					"linux,keypad-wakeup");
> 
> I don't think you mean to invert this.
> 

Good catch. Thanks.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/