A question regarding TG load tracking functions in fair.c

From: Matthew Leach
Date: Fri Feb 28 2014 - 07:04:39 EST


Hi Paul,

I have a question regarding two lines of code in the functions
__update_cfs_rq_tg_load_contrib and __update_tg_runnable_avg. AFAICS
these functions update a load-tracking signal for the local RQ and an
aggregated signal in the TG for all RQs that belong to this TG. The
update is surrounded by conditions:

if (abs(contrib) > cfs_rq->tg_runnable_contrib / 64) {

for __update_tg_runnable_avg and

if (force_update || abs(tg_contrib) > cfs_rq->tg_load_contrib / 8) {

for __update_cfs_rq_tg_load_contrib. Is this an optimisation to prevent
the signals being updated for small variations? Also, could you please
shed some light on the specific numbers used?

Thanks,
--
Matt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/