Re: [PATCH -tip v7 24/26] kprobes: Enlarge hash table to 4096 entries

[Andi Kleen]

Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> writes:

> Currently, since the kprobes expects to be used
> with less than 100 probe points, its hash table
> just has 64 entries. This is too little to handle
> several thousands of probes.
> Enlarge this to 4096 entires which just consumes
> 32KB (on 64bit arch) for better scalability.

32K for a debug feature that most systems never use seems
too large to me.

First can you check if smaller hash tables work too
(perhaps with a better hash, like jhash) 

And then if you enlarge the table please allocate
it dynamically on the first use.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/