Re: [PATCH v2 5/5] bug: Make BUG() call unreachable()

From: Arnd Bergmann
Date: Thu Feb 27 2014 - 14:20:00 EST


On Wednesday 26 February 2014, Josh Triplett wrote:
> This doesn't seem any different than compiling out assert() at runtime
> in a userspace program, given how the kernel uses BUG() and BUG_ON().
> I'd argue that adding unreachable() doesn't seem like it makes the
> current implementation of BUG() any worse; either way if you reach it
> you have a problem.

I think it's better to get a warning about undefined behavior than
to suppress that warning.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/