Re: [RFC][PATCH] staging: Fix build issues with new binder API

From: John Stultz
Date: Thu Feb 27 2014 - 14:04:15 EST


On 02/26/2014 07:34 PM, Greg KH wrote:
> On Wed, Feb 26, 2014 at 02:29:07PM -0800, John Stultz wrote:
>> The new 64bit binder API causes build issues on 32bit ARM
>> due to the lack of 64bit __get_user_asm_* implementation.
> So no one ever tested this out on ARM? Really, that seems odd...

Its my bad, I was focused on the 32bit legacy compatibility code in my
testing because the userspace I have only works with that.

Arve actually warned about this in one of his mails, but I mistakenly
thought it was an issue w/ 3.10 and earlier kernels and had since been
addressed.


> Anyway, if you want this to always be on, that's fine with me, your
> choice :)

I think its the best option for now, but wanted to send it out for
comment to see if anyone objected.

I'm about to head for a conference so I'll be offline until around
Monday. While at the conference I'm going to be working with folks to
see if we can't get the real solution (a __get_user_asm_64
implementation) sorted. But if there are no objections, it might be
best to queue this for staging-next so folks don't hit the issue in the
meantime.

thanks
-john





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/