Re: [PATCH v2 2/3] x86/hash: swap arguments passed to crc32_u32()

From: H. Peter Anvin
Date: Thu Feb 27 2014 - 13:53:33 EST


On 02/27/2014 12:47 AM, Jan Beulich wrote:
> ... to match the function's parameters. While reportedly commutative,
> using the proper order allows for leveraging the instruction permitting
> the source operand to be in memory.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Daniel Borkmann <dborkman@xxxxxxxxxx>
> Cc: Francesco Fusco <ffusco@xxxxxxxxxx>
> Cc: Thomas Graf <tgraf@xxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>

Acked-by: H. Peter Anvin <hpa@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/