Re: [PATCH v2 1/4] pci: OF: Fix the conversion of IO ranges into IO resources.

From: Arnd Bergmann
Date: Thu Feb 27 2014 - 08:21:11 EST


On Thursday 27 February 2014 13:06:39 Liviu Dudau wrote:
> + res->flags = range->flags;
> + if (res->flags & IORESOURCE_IO) {
> + unsigned long port;
> + port = pci_address_to_pio(range->pci_addr);
> + if (port == (unsigned long)-1) {
> + res->start = (resource_size_t)OF_BAD_ADDR;
> + res->end = (resource_size_t)OF_BAD_ADDR;
> + return;
> + }
>

I think this conflicts with the way that pci_address_to_pio() is
defined on powerpc, where it expects a CPU address as the input,
not a PCI i/o address.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/