Re: [RFA][PATCH 3/4] tracing/module: Remove include of tracepoint.h from module.h

[Steven Rostedt]

On Wed, 26 Feb 2014 14:01:43 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> [ Request for Ack ]
> 
> From: "Steven Rostedt (Red Hat)" <rostedt@xxxxxxxxxxx>
> 
> There's nothing in the module.h header that requires tracepoint.h to be
> included. Soon, tracepoint.h will require struct module, and will have to
> include module.h. To avoid include hell, we need to remove the include of
> tracepoint.h from module.h.
> 
> A stable patch will require this change, so include stable in the Cc.
> 
> Cc: stable@xxxxxxxxxxxxxxx # 2.6.31+

Hi Rusty,

This patch doesn't need to be stable, and can wait till v3.15. But I
have other patches that will break with this patch (headers that needed
to include tracepoint.h and not depend on a header chain to include it).

Can you give me your Acked-by for this, and I'll just add it to my 3.15
queue?

Thanks,

-- Steve


> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> ---
>  include/linux/module.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/module.h b/include/linux/module.h
> index eaf60ff..6cc28d9 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -15,7 +15,6 @@
>  #include <linux/stringify.h>
>  #include <linux/kobject.h>
>  #include <linux/moduleparam.h>
> -#include <linux/tracepoint.h>
>  #include <linux/export.h>
>  
>  #include <linux/percpu.h>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/