Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

[Kieran Clancy]

On Thu, Feb 27, 2014 at 10:15 AM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
> On Thursday, February 27, 2014 02:12:40 AM Kieran Clancy wrote:
>> Signed-off-by: Kieran Clancy <clancy.kieran@xxxxxxxxx>
>> Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx>
>> Signed-off-by: Juan Manuel Cabo <juanmanuel.cabo@xxxxxxxxx>
>> Signed-off-by: Dennis Jansen <dennis.jansen@xxxxxx>
>
> There are too many sign-offs under this patch.  I suppose some of them
> should be Acked-by or Reviewed-by.
>
> Are you the author?

Sorry about that, I wasn't sure of the best way to acknowledge the
people involved.

I am the primary author, but I based the loop which calls
acpi_ec_query_unlocked() on a patch by Lan Tianyu. Juan provided the
initial idea (userspace workaround), and Dennis and Lan Tianyu
reviewed and suggested some changes to the code.

What would you usually do this kind of situation?

I suppose I could put something such as:

Signed-off-by: Kieran Clancy <clancy.kieran@xxxxxxxxx>
Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx>
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@xxxxxxxxx>
Reviewed-by: Lan Tianyu <tianyu.lan@xxxxxxxxx>
Reviewed-by: Dennis Jansen <dennis.jansen@xxxxxx>

Would this be preferable?

Thanks,
Kieran Clancy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/