Re: [PATCH v3 1/9] Input: pmic8xxx-pwrkey - Migrate to regmap APIs

[Josh Cartwright]

On Wed, Feb 26, 2014 at 04:20:03PM -0800, Stephen Boyd wrote:
> On 02/26/14 16:13, Josh Cartwright wrote:
> > On Wed, Feb 26, 2014 at 04:05:40PM -0800, Stephen Boyd wrote:
> >> On 02/26/14 15:59, Josh Cartwright wrote:
> > However, I think it needs to be made clear that your if "Modernize pm8921
> > with irqdomains, regmap, DT" lands before this patchset, this will start
> > breaking randconfig builds.  It isn't clear to me how this dependency
> > should be handled.
> >
> 
> Hmm? If pm8921 lands before this what build breakage is there? The
> pm8xxx_read/write APIs are still exposed.

Well, with the pm8921 patchset in place, the keypad driver becomes
selectable, which, when built leads to the error below.  But AFAICT,
this isn't even addressed in this patchset?!

drivers/input/keyboard/pmic8xxx-keypad.c:24:35: fatal error: linux/mfd/pm8xxx/gpio.h: No such file or directory
 #include <linux/mfd/pm8xxx/gpio.h>
                                   ^

So, I'm confused...maybe the pm8921 cleanup patchset should be marking
the keypad driver BROKEN?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/