Re: [PATCH 2/3] x86/hash: swap parameters of crc32_u32()

[H. Peter Anvin]

On 02/26/2014 01:29 AM, Jan Beulich wrote:
> 
> or it would be (with parameter order kept and argument order
> swapped)
> 
> static inline u32 crc32_u32(u32 crc, u32 val)
> 		seed = crc32_u32(seed, *p32++);
> 		seed = crc32_u32(seed, tmp);
> 		seed = crc32_u32(seed, *p32++);
> 
> I.e. it is precisely the case that their names and functions disagree
> in the current (unpatched) version.
> 

I guess I think this version seems more logical especially/when this
inline is moved into a global place somewhere.

It's not a big deal, though.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/