[PATCH 1/1] ALSA: compress: no need to set metadata before next track

From: Richard Fitzgerald
Date: Wed Feb 26 2014 - 09:54:25 EST


The metadata is mainly for MP3 gapless playback, since
the MP3 audio stream does not contain enough information
to enable gapless. Other audio formats do not necessarily
require any additional metadata so we should allow next_track
to be called without any metadata.

Signed-off-by: Zhao Weijia <weijia.zhao@xxxxxxxxxxxx>
Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
---
sound/core/compress_offload.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index 7a20897..5a351c7 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -744,12 +744,6 @@ static int snd_compr_next_track(struct snd_compr_stream *stream)
if (stream->runtime->state != SNDRV_PCM_STATE_RUNNING)
return -EPERM;

- /* you can signal next track isf this is intended to be a gapless stream
- * and current track metadata is set
- */
- if (stream->metadata_set == false)
- return -EPERM;
-
retval = stream->ops->trigger(stream, SND_COMPR_TRIGGER_NEXT_TRACK);
if (retval != 0)
return retval;
--
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/