Re: [PATCH] pwm,renesas-tpu: Add dependency on HAS_IOMEM

From: Thierry Reding
Date: Wed Feb 26 2014 - 07:08:18 EST


On Fri, Jan 31, 2014 at 01:45:18PM +0100, Richard Weinberger wrote:
> On archs like S390 or um this driver cannot build nor work.
> Make it depend on HAS_IOMEM to bypass build failures.
>
> drivers/built-in.o: In function `tpu_probe':
> drivers/pwm/pwm-renesas-tpu.c:421: undefined reference to `devm_ioremap_resource'
>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
> drivers/pwm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

In the long run I think it might be better to add a dummy implementation
for devm_ioremap_resource() in order to make it build properly even for
architectures where it isn't implemented.

For now this looks like the best option. Applied, thanks.

Thierry

Attachment: pgp_4Mz3rfqos.pgp
Description: PGP signature