Re: [PATCH, RFC 08/30] [media] arv: fix sleep_on race

From: Arnd Bergmann
Date: Wed Feb 26 2014 - 03:58:02 EST


On Friday 07 February 2014, Hans Verkuil wrote:
> On 01/17/2014 11:51 AM, Hans Verkuil wrote:

> >> diff --git a/drivers/media/platform/arv.c b/drivers/media/platform/arv.c
> >> index e346d32d..32f6d70 100644
> >> --- a/drivers/media/platform/arv.c
> >> +++ b/drivers/media/platform/arv.c
> >> @@ -307,11 +307,11 @@ static ssize_t ar_read(struct file *file, char *buf, size_t count, loff_t *ppos)
> >> /*
> >> * Okay, kick AR LSI to invoke an interrupt
> >> */
> >> - ar->start_capture = 0;
> >> + ar->start_capture = -1;
> >
> > start_capture is defined as an unsigned. Can you make a new patch that changes
> > the type of start_capture to int?
> >
> > Otherwise it looks fine.


Sorry for the delay. I've updated the patch now and will send it out today
with the other remaining ones.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/