Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

From: Or Gerlitz
Date: Tue Feb 25 2014 - 17:20:18 EST


On Wed, Feb 26, 2014 at 12:11 AM, Jiri Kosina <jkosina@xxxxxxx> wrote:
> On Tue, 25 Feb 2014, Or Gerlitz wrote:

>> And what happens if you use IPoIB datagram mode, is/why the patch is
>> needed there?

> I admittedly am no infiniband expert, but my understanding is that in
> principle Connected/Datagram mode is about MTU and checksum offloading,

yes, the differences between the mode relate to these aspects, however

> but the TX path is the same. Please correct me if I am wrong.

no, note that your patch only touched drivers/infiniband/ulp/ipoib/ipoib_cm.c
which is basically compiled out if you set CONFIG_INFINIBAND_IPOIB_CM,
so surely the TX path for the datagram vs. connected modes are
different.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/