Re: [PATCH 2/2] pinctrl: sh-pfc: r8a7791: Add alternative MSIOF pin groups

[Geert Uytterhoeven]

Hi Laurent,

On Tue, Feb 25, 2014 at 6:19 PM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>> +static const unsigned int msiof1_rx_d_pins[] = {
>> +     /* RXD */
>> +     RCAR_GP_PIN(0, 26),
>
> This should be (0, 27).

Wow, nice catch. Thanks a lot!

>> +static const unsigned int msiof2_ss2_d_pins[] = {
>> +     /* SS2 */
>> +     RCAR_GP_PIN(2, 18),
>
> This should be (2, 19).

p. 4-16 of Rev. 0.31 of the R-Car M2 datasheet states that GP2_18 can be
both MSIOF2_SS2_D (function 3) and MSIOF2_RXD_D (function 5),
but p. 5-37 disagrees?
It seems the whole function 3 column on p. 4-16 is offset by one,
compared to p. 5-37.

Well, (2, 19) sounds more logical, so let's assume p. 5-37 is correct for now.

> > +};
> > +static const unsigned int msiof2_ss2_d_mux[] = {
> > +     MSIOF2_SS2_D_MARK,
> > +};
> > +static const unsigned int msiof2_rx_d_pins[] = {
> > +     /* RXD */
> > +     RCAR_GP_PIN(2, 18),
> > +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/