Re: [PATCH] i8042: Don't print an error message just because there's no chip

[Josh Boyer]

On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@xxxxxxxxxx> wrote:
> From: Peter Jones <pjones@xxxxxxxxxx>
>
> Some systems, such as EFI-based Apple systems, won't necessarily have an
> i8042 to initialize. We shouldn't be printing an error message in this
> case, since not detecting the chip is the correct behavior.
>
> v2: Downgrade to pr_notice instead of pr_err.
>
> Signed-off-by: Adam Jackson <ajax@xxxxxxxxxx>

Reviewed-by:  Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>

> ---
>  drivers/input/serio/i8042.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> index 020053f..05c6285 100644
> --- a/drivers/input/serio/i8042.c
> +++ b/drivers/input/serio/i8042.c
> @@ -855,7 +855,7 @@ static int __init i8042_check_aux(void)
>  static int i8042_controller_check(void)
>  {
>         if (i8042_flush()) {
> -               pr_err("No controller found\n");
> +               pr_notice("No controller found\n");
>                 return -ENODEV;
>         }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/