RE: [patch 24/26] genirq: Provide handle_percpu_simple_irq()

From: KY Srinivasan
Date: Tue Feb 25 2014 - 07:25:54 EST




> -----Original Message-----
> From: Thomas Gleixner [mailto:tglx@xxxxxxxxxxxxx]
> Sent: Sunday, February 23, 2014 1:40 PM
> To: LKML
> Cc: Ingo Molnar; Peter Zijlstra; KY Srinivasan; Greg Kroah-Hartman
> Subject: [patch 24/26] genirq: Provide handle_percpu_simple_irq()
>
> Special case for vmbus to replace their homegrown flow handler.
>
> Not sure whether we need it at all. I can't see a reason why that needs
> special handling at all if CONFIG_HYPERV=n

Thomas,

Thank you for cleaning up this code. All of the VMBUS code is active only if CONFIG_HYPERV is set.

Regards,

K. Y

>
> Not-Yet-Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> include/linux/irq.h | 1 +
> kernel/irq/chip.c | 15 +++++++++++++++
> 2 files changed, 16 insertions(+)
>
> Index: tip/include/linux/irq.h
> ==========================================================
> =========
> --- tip.orig/include/linux/irq.h
> +++ tip/include/linux/irq.h
> @@ -423,6 +423,7 @@ extern void handle_edge_irq(unsigned int extern
> void handle_edge_eoi_irq(unsigned int irq, struct irq_desc *desc); extern
> void handle_simple_irq(unsigned int irq, struct irq_desc *desc); extern void
> handle_percpu_irq(unsigned int irq, struct irq_desc *desc);
> +extern void handle_percpu_simple_irq(unsigned int irq, struct irq_desc
> +*desc);
> extern void handle_percpu_devid_irq(unsigned int irq, struct irq_desc
> *desc); extern void handle_bad_irq(unsigned int irq, struct irq_desc *desc);
> extern void handle_nested_irq(unsigned int irq);
> Index: tip/kernel/irq/chip.c
> ==========================================================
> =========
> --- tip.orig/kernel/irq/chip.c
> +++ tip/kernel/irq/chip.c
> @@ -623,6 +623,21 @@ handle_percpu_irq(unsigned int irq, stru }
>
> /**
> + * handle_percpu_simple_irq - Per CPU local irq handler
> + * @irq: the interrupt number
> + * @desc: the interrupt description structure for this irq
> + *
> + * Per CPU interrupts on SMP machines without locking
> + * requirements. No ack/eoi handling.
> + */
> +void
> +handle_percpu_simple_irq(unsigned int irq, struct irq_desc *desc) {
> + kstat_incr_irqs_this_cpu(irq, desc);
> + handle_irq_event_percpu(desc, desc->action); }
> +
> +/**
> * handle_percpu_devid_irq - Per CPU local irq handler with per cpu dev ids
> * @irq: the interrupt number
> * @desc: the interrupt description structure for this irq
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/