Re: [PATCH] r8169: initialize rtl8169_stats seqlock

From: Borislav Petkov
Date: Tue Feb 25 2014 - 02:50:30 EST


On Mon, Feb 24, 2014 at 08:32:40PM -0500, David Miller wrote:
> > Boris reports he's seeing:
> >> [ 9.195943] INFO: trying to register non-static key.
> >> [ 9.196031] the code is fine but needs lockdep annotation.
> >> [ 9.196031] turning off the locking correctness validator.
> >> [ 9.196031] CPU: 1 PID: 933 Comm: modprobe Not tainted 3.14.0-rc4+ #1
> > with the r8169 driver.
> >
> > These are occuring because the seqcount embedded in u64_stats_sync on
> > 32-bit SMP is uninitialized which is making lockdep unhappy.
> >
> > Signed-off-by: Kyle McMartin <kyle@xxxxxxxxxx>
>
> Good catch, applied, thanks Kyle.

Thanks Kyle!

Tested-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/