Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse

From: Bjorn Helgaas
Date: Mon Feb 24 2014 - 18:03:49 EST


On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Mon, 24 Feb 2014, Bjorn Helgaas wrote:
>> On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
>> > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
>> >>
>> >> There is no reason to care about irq_desc in that context, escpecially
>> >> as irq_data for that interrupt is retrieved as well.
>> >>
>> >> Use the proper accessor for the msi descriptor
>> >>
>> >> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> >> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>> >> Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>
>> >> Cc: Mohit Kumar <mohit.kumar@xxxxxx>
>> >> Cc: pci <linux-pci@xxxxxxxxxxxxxxx>
>> >
>> > Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
>>
>> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>>
>> Thomas, I assume you'll merge this along with the rest of your series.
>> I don't have any pending changes in this area.
>
> I can do, but it does not depend on anything else, so you can pick it
> up as well. Either way is fine.

I never know what to do with these. I suggested that you pick it up
so the whole series would be together, because I assumed it would make
more sense in the git history to have all these similar changes
grouped together. But maybe that really doesn't matter.

What's the recommended practice?

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/