Re: [PATCH 4/6] android: convert sync to fence api, v4

From: Maarten Lankhorst
Date: Mon Feb 24 2014 - 08:01:33 EST


op 19-02-14 14:56, Thomas Hellstrom schreef:
>+static void fence_check_cb_func(struct fence *f, struct fence_cb *cb)
>+{
>+ struct sync_fence_cb *check = container_of(cb, struct sync_fence_cb, cb);
>+ struct sync_fence *fence = check->fence;
>+
>+ // TODO: Add a fence->status member and check it
Hmm, C++ / C99 style comments makes checkpatch.pl complain. Did you run
this series through checkpatch?

/Thomas

Actually I used c99 here because it shouldn't have been in the sent patch. ;-)

Right below that comment I use fence->status, so the right thing to do was to zap the comment.

Thanks for catching it!

~Maarten\
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/