Re: [PATCH 2/3] x86/hash: swap parameters of crc32_u32()

From: H. Peter Anvin
Date: Mon Feb 24 2014 - 07:36:01 EST


On 02/24/2014 12:03 AM, Jan Beulich wrote:
rte_hash_crc_4byte(uint32_t data, uint32_t init_val)

as opposed to

static inline u32 crc32_u32(u32 crc, u32 val)

(quite obviously data <-> val and crc <-> init_val, supported
by the second argument in each caller being named "seed").


"Quite obviously", but unfortunately wrong (see other email).

-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/