Re: [PATCH] of/gpio: Define OF_GPIO_OPEN_DRAIN flag for Open Drain outputs.

[Linus Walleij]

On Mon, Feb 10, 2014 at 11:05 PM, David Daney <ddaney.cavm@xxxxxxxxx> wrote:

> From: David Daney <david.daney@xxxxxxxxxx>
>
> When we have a GPIO pin connected to an open-drain network, we want a
> standard way of specifying this in the device tree.  So we choose bit
> 1 of the flag field to indicate open drain.

This is a good idea.

But the patch is missing two things:

- Add open source as well, as indicated.

- Add this definition to include/dt-bindings/gpio/gpio.h

- Add this *and* the missing active low property to the binding
  documentation in:
  Documentation/devicetree/bindings/gpio/gpio.txt
  (pls help with this!)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/