RE: [PATCH RESEND v2 1/3] usb: chipidea: msm: Add device tree binding information

From: Peter Chen
Date: Mon Feb 24 2014 - 05:34:57 EST



>
> On Mon, 2014-02-24 at 08:15 +0000, Peter Chen wrote:
> > > +CI13xxx (Chipidea) USB controllers
> > > +
> > > +Required properties:
> > > +- compatible: should contain "qcom,ci-hdrc"
> > > +- reg: offset and length of the register set in the memory
> map
> > > +- interrupts: interrupt-specifier for the controller interrupt.
> > > +- usb-phy: phandle for the PHY device
> > > +- dr_mode: Sould be "peripheral"
> > > +
> > > + gadget@f9a55000 {
> > > + compatible = "qcom,ci-hdrc";
> > > + reg = <0xf9a55000 0x400>;
> > > + dr_mode = "peripheral";
> > > + interrupts = <0 134 0>;
> > > + usb-phy = <&usb_otg>;
> > > + };
> > > +
> >
> > usb_otg is not a good name for the node of usb phy.
>
> Well, this is just an example. Is this better <&phy0>?
>

<&usbphy0> is better since we have ethernet, sata, pcie phy.

Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/